Skip to content

vperez/test delta byte array file reader #46353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MetalBlueberry wants to merge 1 commit into from
Closed

vperez/test delta byte array file reader #46353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/submodules/parquet-testing
Open in desktop
Submodule parquet-testing updated 28 files
+43 −0 .asf.yaml
+ − bad_data/ARROW-GH-41317.parquet
+ − bad_data/ARROW-GH-41321.parquet
+ − bad_data/ARROW-GH-43605.parquet
+ − bad_data/ARROW-GH-45185.parquet
+ − bad_data/ARROW-RS-GH-6229-DICTHEADER.parquet
+ − bad_data/ARROW-RS-GH-6229-LEVELS.parquet
+12 −1 bad_data/README.md
+63 −0 data/README.md
+ − data/alltypes_dictionary.parquet
+ − data/alltypes_plain.parquet
+ − data/alltypes_plain.snappy.parquet
+ − data/column_chunk_key_value_metadata.parquet
+ − data/encrypt_columns_and_footer.parquet.encrypted
+ − data/encrypt_columns_and_footer_aad.parquet.encrypted
+ − data/encrypt_columns_and_footer_ctr.parquet.encrypted
+ − data/encrypt_columns_and_footer_disable_aad_storage.parquet.encrypted
+ − data/encrypt_columns_plaintext_footer.parquet.encrypted
+ − data/incorrect_map_schema.parquet
+164 −0 data/map_no_value.md
+ − data/map_no_value.parquet
+ − data/nan_in_stats.parquet
+103 −0 data/old_list_structure.md
+ − data/old_list_structure.parquet
+ − data/page_v2_empty_compressed.parquet
+ − data/repeated_primitive_no_list.parquet
+ − data/sort_columns.parquet
+ − data/uniform_encryption.parquet.encrypted
53 changes: 53 additions & 0 deletions go/parquet/file/file_reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ package file_test

import (
"bytes"
"context"
"crypto/rand"
"encoding/binary"
"encoding/csv"
"io"
"os"
"path"
Expand All @@ -34,6 +36,7 @@ import (
format "github.com/apache/arrow/go/v17/parquet/internal/gen-go/parquet"
"github.com/apache/arrow/go/v17/parquet/internal/thrift"
"github.com/apache/arrow/go/v17/parquet/metadata"
"github.com/apache/arrow/go/v17/parquet/pqarrow"
"github.com/apache/arrow/go/v17/parquet/schema"
libthrift "github.com/apache/thrift/lib/go/thrift"
"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -446,3 +449,53 @@ func TestRleBooleanEncodingFileRead(t *testing.T) {

assert.Equal(t, expected, values[:len(expected)])
}

func TestDeltaByteArray(t *testing.T) {
dir := os.Getenv("PARQUET_TEST_DATA")
if dir == "" {
t.Skip("no path supplied with PARQUET_TEST_DATA")
}
require.DirExists(t, dir)

expected, err := os.ReadFile(path.Join(dir, "delta_byte_array_expect.csv"))
require.NoError(t, err)
csvReader := csv.NewReader(bytes.NewReader(expected))

records, err := csvReader.ReadAll()
require.NoError(t, err)

records = records[1:] // skip header

props := parquet.NewReaderProperties(memory.DefaultAllocator)
fileReader, err := file.OpenParquetFile(path.Join(dir, "delta_byte_array.parquet"),
false, file.WithReadProps(props))
require.NoError(t, err)
defer fileReader.Close()

arrowReader, err := pqarrow.NewFileReader(
fileReader,
pqarrow.ArrowReadProperties{BatchSize: 1024},
memory.DefaultAllocator,
)
require.NoError(t, err)

rr, err := arrowReader.GetRecordReader(context.Background(), nil, nil)
require.NoError(t, err)
defer rr.Release()

for rr.Next() {
rec := rr.Record()
defer rec.Release()

for i := 0; i < int(rec.NumCols()); i++ {
vals := rec.Column(i)
for j := 0; j < vals.Len(); j++ {
if vals.IsNull(j) {
require.Equal(t, records[j][i], "")
continue
}
require.Equal(t, records[j][i], vals.ValueStr(j))
}
}
}
}
Loading