Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented May 14, 2025

Rationale for this change

New functionality breaks tests with minimal builds

What changes are included in this PR?

Skip tests on those builds

Are these changes tested?

Updates are to tests

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #46442 has been automatically assigned in GitHub to PR creator.

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions
Copy link

Revision: 57053c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-6688d1c6a9

Task Status
test-r-rstudio-r-base-4.1-opensuse155 Azure

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions
Copy link

Revision: 630d86d

Submitted crossbow builds: ursacomputing/crossbow @ actions-b650454563

Task Status
test-r-rstudio-r-base-4.1-opensuse155 Azure

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

@github-actions
Copy link

Revision: 4dc5da1

Submitted crossbow builds: ursacomputing/crossbow @ actions-5d72b91ecf

Task Status
test-r-rstudio-r-base-4.1-opensuse155 Azure

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-minimal-build test-r-offline-minimal test-r-rstudio-r-base-4.1-opensuse155 test-r-rstudio-r-base-4.2-focal test-r-versions

@github-actions
Copy link

Revision: 4dc5da1

Submitted crossbow builds: ursacomputing/crossbow @ actions-e706ba361a

Task Status
test-r-minimal-build Azure
test-r-offline-minimal Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-versions GitHub Actions

@thisisnic thisisnic marked this pull request as ready for review May 15, 2025 00:41
@thisisnic thisisnic requested a review from jonkeane as a code owner May 15, 2025 00:41
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 15, 2025
@thisisnic thisisnic merged commit 1521148 into apache:main May 15, 2025
12 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label May 15, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1521148.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants