-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-43623: [R] remove libarrow backwards compatibility enforcement #46491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit -g r |
|
Revision: bf18353 Submitted crossbow builds: ursacomputing/crossbow @ actions-a14f05c971 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| template <typename T> | ||
| using Pointer = cpp11::external_pointer<std::shared_ptr<T>, DeletePointer<T>>; | ||
|
|
||
| #if ARROW_VERSION_MAJOR >= 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this required for the test-r-arrow-backwards-compatibility job too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we use binaries for that job — though that job is failing for other reasons I need to figure out (https://github.com/ursacomputing/crossbow/actions/runs/15090630647/job/42418790800 is last night's run on main with the same failure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
After this merges, I'll take a look at rebasing #41998 as it removes the one thing we weren't sure about there |
😦 We've blocked things for ~1 year due to this 😦 That's unfortunate. But, yes, please! 🙏 I think technically that could merge now since we bumped to 19.0.1 a little while ago already, but waiting until this PR merges is also totally fine. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 218c886. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Remove checks and enforcement of minimum versions. See discussion in the issue. This caused more confusion and discussion than it was helpful. We have the CI in git history if we need it.
What changes are included in this PR?
Removing the CI job
Are these changes tested?
They are the tests
Are there any user-facing changes?
No, we are still technically compatible with 19.0.1, but we don't explicitly support that or use it anywhere. The R package version should match the libarrow version to ensure compatibility — using anything else might work but is off label.