Skip to content

Conversation

@jonkeane
Copy link
Member

@jonkeane jonkeane commented May 18, 2025

Rationale for this change

Remove checks and enforcement of minimum versions. See discussion in the issue. This caused more confusion and discussion than it was helpful. We have the CI in git history if we need it.

What changes are included in this PR?

Removing the CI job

Are these changes tested?

They are the tests

Are there any user-facing changes?

No, we are still technically compatible with 19.0.1, but we don't explicitly support that or use it anywhere. The R package version should match the libarrow version to ensure compatibility — using anything else might work but is off label.

@github-actions
Copy link

⚠️ GitHub issue #43623 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 18, 2025
@jonkeane
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: bf18353

Submitted crossbow builds: ursacomputing/crossbow @ actions-a14f05c971

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 19, 2025
template <typename T>
using Pointer = cpp11::external_pointer<std::shared_ptr<T>, DeletePointer<T>>;

#if ARROW_VERSION_MAJOR >= 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this required for the test-r-arrow-backwards-compatibility job too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we use binaries for that job — though that job is failing for other reasons I need to figure out (https://github.com/ursacomputing/crossbow/actions/runs/15090630647/job/42418790800 is last night's run on main with the same failure)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels May 19, 2025
@thisisnic
Copy link
Member

After this merges, I'll take a look at rebasing #41998 as it removes the one thing we weren't sure about there

@jonkeane
Copy link
Member Author

After this merges, I'll take a look at rebasing #41998 as it removes the one thing we weren't sure about there

😦 We've blocked things for ~1 year due to this 😦 That's unfortunate.

But, yes, please! 🙏 I think technically that could merge now since we bumped to 19.0.1 a little while ago already, but waiting until this PR merges is also totally fine.

@jonkeane jonkeane merged commit 218c886 into apache:main May 26, 2025
13 checks passed
@jonkeane jonkeane removed the awaiting changes Awaiting changes label May 26, 2025
@jonkeane jonkeane deleted the 43623_remove_compatibility branch May 26, 2025 14:33
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 218c886.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants