GH-46496: [CI][Dev] Fix shellcheck SC2086 errors in ci/scripts directory #46497
Conversation
hiroyuki-sato
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
|
I modified many files at once. But, all of changes are Please let me know, it would be better to split this into multiple PRs. |
There was a problem hiding this comment.
Could you remove this file in a separated PR?
We moved the Java implementation to apache/arrow-java.
There was a problem hiding this comment.
OK. Should I also remove ci/scripts/rust_build.sh too?
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index fe178e069..3ef23a08e 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -196,13 +196,31 @@ repos:
?^ci/scripts/c_glib_build\.sh$|
?^ci/scripts/c_glib_test\.sh$|
?^ci/scripts/conan_setup\.sh$|
+ ?^ci/scripts/csharp_build\.sh$|
+ ?^ci/scripts/csharp_pack\.sh$|
?^ci/scripts/download_tz_database\.sh$|
?^ci/scripts/install_azurite\.sh$|
?^ci/scripts/install_ccache\.sh$|
?^ci/scripts/install_ceph\.sh$|
+ ?^ci/scripts/install_chromedriver\.sh$|
+ ?^ci/scripts/install_cmake\.sh$|
+ ?^ci/scripts/install_emscripten\.sh$|
+ ?^ci/scripts/install_iwyu\.sh$|
+ ?^ci/scripts/install_ninja\.sh$|
+ ?^ci/scripts/install_numpy\.sh$|
+ ?^ci/scripts/install_pandas\.sh$|
+ ?^ci/scripts/install_python\.sh$|
?^ci/scripts/install_spark\.sh$|
+ ?^ci/scripts/install_vcpkg\.sh$|
?^ci/scripts/integration_dask\.sh$|
+ ?^ci/scripts/java_full_build\.sh$|
+ ?^ci/scripts/matlab_build\.sh$|
+ ?^ci/scripts/msys2_system_clean\.sh$|
?^ci/scripts/msys2_system_upgrade\.sh$|
+ ?^ci/scripts/python_sdist_build\.sh$|
+ ?^ci/scripts/release_test\.sh$|
+ ?^ci/scripts/ruby_test\.sh$|
+ ?^ci/scripts/rust_build\.sh$|
?^ci/scripts/util_free_space\.sh$|
?^cpp/build-support/build-lz4-lib\.sh$|
?^cpp/build-support/build-zstd-lib\.sh$|There was a problem hiding this comment.
It's used here:
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit -g python |
|
Could you open a new issue for MATLAB CI failures? |
|
Revision: f1917a8 Submitted crossbow builds: ursacomputing/crossbow @ actions-c037629e6f
|
|
I created #46498 for MATLAB CI Failure. |
github-actions
bot
added
awaiting change review
|
It seems that the following error are know issues.
Rest of two are the same error.
https://github.com/ursacomputing/crossbow/actions/runs/15107317228/job/42458657050#step:3:13178 |
|
@github-actions crossbow submit example-python-minimal-build-fedora-conda |
|
|
|
Revision: 709f074 Submitted crossbow builds: ursacomputing/crossbow @ actions-0b8afc1ec8
|
|
The failure on the You can either push the dev tags from the apache/arrow repo to your fork or ignore those failures. We should fix the issue I've shared as this is recurring for new contributions :) |
|
@raulcd Thanks! I pushed tag to my repository. |
|
@github-actions crossbow submit example-python-minimal-build-fedora-conda |
|
Revision: 709f074 Submitted crossbow builds: ursacomputing/crossbow @ actions-33609c0757
|
|
@kou crossbow failure are known issues. I think crossbow passed. Please take a look when you get a chance. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ddfa762. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
3 participants
Rationale for this change
We are trying to implement shellcheck on all sh files in #44748.
What changes are included in this PR?
SC2086 check requires quoting like
${url}->"${url}".Are these changes tested?
Yes.
Are there any user-facing changes?
No.