Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented May 22, 2025

Rationale for this change

Since we merged:

The fallback case were dataset is not available is not being tested on parquet.read_table (I did validate myself with a breakpoint).

What changes are included in this PR?

Adds a basic test that checks the exercises that code path and tests the read_table method from ParquetFile instead of ParquetDataset in case dataset is not available.

Are these changes tested?

Yes via CI.

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #46373 has been automatically assigned in GitHub to PR creator.

@raulcd raulcd marked this pull request as ready for review May 22, 2025 10:31
@raulcd raulcd requested review from AlenkaF and rok as code owners May 22, 2025 10:31
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this @raulcd!

@raulcd raulcd merged commit d028fa8 into apache:main May 26, 2025
15 of 16 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label May 26, 2025
@raulcd raulcd deleted the GH-46373 branch May 26, 2025 08:55
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d028fa8.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants