Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented May 27, 2025

See #41998 - rebase was too messy due to PR age so did this manually.

@thisisnic thisisnic changed the title GH-41973: Expose new S3 option check_directory_existence_before_creation - manul rebase GH-41973: Expose new S3 option check_directory_existence_before_creation - manual rebase May 27, 2025
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

Comment on lines +152 to +155
# TODO - update the script to add this back in - will fail CI as tries to link
# to non-existent function as arrow::one only exists as registered binding
docs[["arrow::one"]] <- NULL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do this now? Or is this a thing for later? If later, do we have an issue for it? I'm not sure I fully get what the comment is saying (but will admit I haven't dug too much right now)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So without it we were getting the warning shown here: https://github.com/apache/arrow/actions/runs/15282844766/job/42985877041#step:5:612

I don't think we need to do it now, I will open a ticket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting merge Awaiting merge labels May 28, 2025
@thisisnic thisisnic merged commit bd2c070 into apache:main May 29, 2025
13 checks passed
@thisisnic thisisnic removed the awaiting changes Awaiting changes label May 29, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bd2c070.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants