-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-41973: Expose new S3 option check_directory_existence_before_creation - manual rebase #46619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment
| # TODO - update the script to add this back in - will fail CI as tries to link | ||
| # to non-existent function as arrow::one only exists as registered binding | ||
| docs[["arrow::one"]] <- NULL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do this now? Or is this a thing for later? If later, do we have an issue for it? I'm not sure I fully get what the comment is saying (but will admit I haven't dug too much right now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So without it we were getting the warning shown here: https://github.com/apache/arrow/actions/runs/15282844766/job/42985877041#step:5:612
I don't think we need to do it now, I will open a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bd2c070. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
See #41998 - rebase was too messy due to PR age so did this manually.