-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46773: [GLib] Add GArrowFixedSizeListDataType #46774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kou
merged 30 commits into
apache:main
from
hiroyuki-sato:topic/fixed-size-list-data-type
Jun 17, 2025
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
66fa6f3
GH-46773: [GLib] Add GArrowFixedSizeListDataType
hiroyuki-sato d36815a
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 5a3b7dc
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 6e4f754
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato daf545e
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 9af3ecc
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 539d3fa
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 89c0c02
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 0174b5a
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 8b3f71d
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato c7a7f15
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 3378ed6
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato 203b45f
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato 300648a
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato f68e01c
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato fad642d
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato 6632e5e
GH-46773: [GLib] Add GArrowFixedSizeListDataType
hiroyuki-sato 9f6894f
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 7703330
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 5359b53
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato 64314cc
Update c_glib/arrow-glib/composite-data-type.h
hiroyuki-sato 9a0e7d5
GH-46773: [GLib] Add GArrowFixedSizeListDataType
hiroyuki-sato 3cfa7bf
Fix test
hiroyuki-sato 62d8911
Simplified test
hiroyuki-sato 11ed2b4
Add class description
hiroyuki-sato 5519593
Implement field and list_size
hiroyuki-sato e2f6c2c
Fix lint
hiroyuki-sato 8a9adec
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato e7b4ea4
Update c_glib/test/test-fixed-size-list-data-type.rb
hiroyuki-sato bb75305
Update c_glib/arrow-glib/composite-data-type.cpp
hiroyuki-sato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| class TestFixedSizeListDataType < Test::Unit::TestCase | ||
| sub_test_case(".new") do | ||
| def test_field | ||
| list_size = 5 | ||
| field_name = "bool_field" | ||
| field = Arrow::Field.new("bool_field", Arrow::BooleanDataType.new) | ||
| data_type = Arrow::FixedSizeListDataType.new(field, list_size) | ||
| assert_equal([field, list_size], [data_type.field, data_type.list_size]) | ||
| end | ||
|
|
||
| def test_data_type | ||
| value_type = Arrow::BooleanDataType.new | ||
| list_size = 5 | ||
| data_type = Arrow::FixedSizeListDataType.new(value_type, list_size) | ||
| field = Arrow::Field.new("item", value_type) | ||
| assert_equal([field, list_size], [data_type.field, data_type.list_size]) | ||
| end | ||
| end | ||
|
|
||
| sub_test_case("instance_methods") do | ||
| def setup | ||
| @list_size = 5 | ||
| @value_type = Arrow::BooleanDataType.new | ||
| @data_type = Arrow::FixedSizeListDataType.new(@value_type, @list_size) | ||
| end | ||
|
|
||
| def test_name | ||
| assert_equal("fixed_size_list", @data_type.name); | ||
| end | ||
|
|
||
| def test_to_s | ||
| assert_equal("fixed_size_list<item: bool>[5]", @data_type.to_s) | ||
hiroyuki-sato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| end | ||
|
|
||
| def test_list_size | ||
| assert_equal(@list_size, @data_type.list_size) | ||
| end | ||
|
|
||
| def test_field | ||
| field = Arrow::Field.new("item", @value_type) | ||
| assert_equal(field, @data_type.field) | ||
| end | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.