-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46771: [Python][C++] Implement pa.arange function to generate array sequences #46778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0880cce
[Python][C++] Implement pa.arange function to generate array sequences
raulcd 8be210c
Avoid unnecessary double/int64_t conversions
raulcd e38a78d
Add option memory pool, fix step == 0, improve docstrings and add mor…
raulcd 3637fef
Move Arange C++ function to arrow/python/util.{h,cc}
raulcd 69c6fdf
Review comments. Release the gil when calling Arange and remove stray…
raulcd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "arrow/python/util.h" | ||
|
|
||
| #include "arrow/array.h" | ||
| #include "arrow/python/common.h" | ||
|
|
||
| namespace arrow ::py { | ||
|
|
||
| Result<std::shared_ptr<Array>> Arange(int64_t start, int64_t stop, int64_t step, | ||
| MemoryPool* pool) { | ||
| int64_t size; | ||
| if (step == 0) { | ||
| return Status::Invalid("Step must not be zero"); | ||
| } | ||
| if (step > 0 && stop > start) { | ||
| // Ceiling division for positive step | ||
| size = (stop - start + step - 1) / step; | ||
| } else if (step < 0 && stop < start) { | ||
| // Ceiling division for negative step | ||
| size = (start - stop - step - 1) / (-step); | ||
| } else { | ||
| return MakeEmptyArray(int64()); | ||
| } | ||
| std::shared_ptr<Buffer> data_buffer; | ||
| ARROW_ASSIGN_OR_RAISE(data_buffer, AllocateBuffer(size * sizeof(int64_t), pool)); | ||
| auto values = reinterpret_cast<int64_t*>(data_buffer->mutable_data()); | ||
| for (int64_t i = 0; i < size; ++i) { | ||
| values[i] = start + i * step; | ||
| } | ||
| auto data = ArrayData::Make(int64(), size, {nullptr, data_buffer}, 0); | ||
| return MakeArray(data); | ||
| } | ||
|
|
||
| } // namespace arrow::py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "arrow/python/common.h" | ||
| #include "arrow/python/visibility.h" | ||
|
|
||
| namespace arrow::py { | ||
|
|
||
| /// \brief Create an array of evenly spaced values within a given interval. | ||
| /// This function is similar to Python's `range` function. | ||
| /// The resulting array will contain values starting from `start` up to but not | ||
| /// including `stop`, with a step size of `step`. If `step` is zero, the function | ||
| /// will return an error. | ||
| /// The resulting array will have a data type of `int64`. | ||
| /// \param[in] start initial value of the sequence. | ||
| /// \param[in] stop final value of the sequence (exclusive). | ||
| /// \param[in] step step size between consecutive values. | ||
| /// \param[in] pool Memory pool for any memory allocations. | ||
| /// \return Result Array | ||
| ARROW_PYTHON_EXPORT | ||
| Result<std::shared_ptr<Array>> Arange(int64_t start, int64_t stop, int64_t step, | ||
| MemoryPool* pool); | ||
|
|
||
| } // namespace arrow::py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.