Skip to content

GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) #46834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 6 commits into from
Jun 20, 2025
Merged

GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) #46834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6483e7
GH-46831: [R] Update SystemRequirements with required CMake >= 3.25
raulcd Jun 17, 2025
1f24aa0
Update building.rst docs to match CMake version
raulcd Jun 17, 2025
f0310e6
Get rid of CMake 3.16 references completely
raulcd Jun 20, 2025
f7581de
Revert change on ci/conan/all/test_package/CMakeLists.txt
raulcd Jun 20, 2025
e4c22e3
Revert conan changes to update on a follow up PR
raulcd Jun 20, 2025
97484ad
Remove stray file
raulcd Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5303,16 +5303,6 @@ endif()
# Azure SDK for C++

function(build_azure_sdk)
if(CMAKE_VERSION VERSION_LESS 3.22)
# We can't disable installing Azure SDK for C++ by
# "set_property(DIRECTORY ${azure_sdk_SOURCE_DIR} PROPERTY
# EXCLUDE_FROM_ALL TRUE)" with CMake 3.16.
#
# At least CMake 3.22 on Ubuntu 22.04 works. So we use 3.22
# here. We may be able to use more earlier version here.
message(FATAL_ERROR "Building Azure SDK for C++ requires at least CMake 3.22. "
"(At least we can't use CMake 3.16)")
endif()
message(STATUS "Building Azure SDK for C++ from source")
fetchcontent_declare(azure_sdk
${FC_DECLARE_COMMON_OPTIONS}
Expand Down
2 changes: 1 addition & 1 deletion cpp/examples/minimal_build/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.

cmake_minimum_required(VERSION 3.16)
cmake_minimum_required(VERSION 3.25)

project(ArrowMinimalExample)

Expand Down
4 changes: 2 additions & 2 deletions docs/source/developers/cpp/building.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Building requires:

* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be
sufficient. For Windows, at least Visual Studio VS2017 is required.
* CMake 3.16 or higher
* CMake 3.25 or higher
* On Linux and macOS, either ``make`` or ``ninja`` build utilities
* At least 1GB of RAM for a minimal build, 4GB for a minimal
debug build with tests and 8GB for a full build using
Expand Down Expand Up @@ -451,7 +451,7 @@ several times with different options if you want to exercise all of them.
CMake version requirements
~~~~~~~~~~~~~~~~~~~~~~~~~~

We support CMake 3.16 and higher.
We support CMake 3.25 and higher.

LLVM and Clang Tools
~~~~~~~~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion r/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ BugReports: https://github.com/apache/arrow/issues
Encoding: UTF-8
Language: en-US
SystemRequirements: C++17; for AWS S3 support on Linux, libcurl and openssl (optional);
cmake >= 3.16 (build-time only, and only for full source build)
cmake >= 3.25 (build-time only, and only for full source build)
Biarch: true
Imports:
assertthat,
Expand Down
Loading