ARROW-5690: [Packaging][Python] Fix macOS wheel building #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Perhaps @kou has an idea. |
Member
|
We should check the crossbow builds once #4675 is merged. |
Member
|
I'm fine with the temporary workaround unless a better solution comes up |
Member
|
@ursabot crossbow package wheel-osx-cp27m wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-win-cp35m wheel-win-cp36m wheel-win-cp37m |
|
AMD64 Conda Crossbow (#25655) builder has been succeeded. Revision: d8e6410 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-72
|
Member
|
Requested the |
wesm
approved these changes
Jun 25, 2019
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. The Python 2.7 wheel build failed in the deploy step but otherwise looks fine
Member
|
I think that |
This was referenced Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the macOS wheels for me. There should be a better way to make the linking against grpc static, let me know if you have any ideas (any flags in CMake that could be set?).