-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-34577 [Python] Expose eol and null_string csv WriteOptions #46976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MartinNowak
wants to merge
1
commit into
apache:main
Choose a base branch
from
MartinNowak:fix-34577-expand-csv-write-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1355,6 +1355,10 @@ cdef class WriteOptions(_Weakrefable): | |
| CSV data | ||
| delimiter : 1-character string, optional (default ",") | ||
| The character delimiting individual cells in the CSV data. | ||
| eol : str, optional (default "\\n") | ||
| The end of line character to use for ending rows | ||
| null_string : str, optional (default "") | ||
| The string to write for null values. Quotes are not allowed in this string. | ||
| quoting_style : str, optional (default "needed") | ||
| Whether to quote values, and if so, which quoting style to use. | ||
| The following values are accepted: | ||
|
|
@@ -1370,14 +1374,18 @@ cdef class WriteOptions(_Weakrefable): | |
| __slots__ = () | ||
|
|
||
| def __init__(self, *, include_header=None, batch_size=None, | ||
| delimiter=None, quoting_style=None): | ||
| delimiter=None, eol=None, null_string=None, quoting_style=None): | ||
| self.options.reset(new CCSVWriteOptions(CCSVWriteOptions.Defaults())) | ||
| if include_header is not None: | ||
| self.include_header = include_header | ||
| if batch_size is not None: | ||
| self.batch_size = batch_size | ||
| if delimiter is not None: | ||
| self.delimiter = delimiter | ||
| if eol is not None: | ||
| self.eol = eol | ||
| if null_string is not None: | ||
| self.null_string = null_string | ||
|
||
| if quoting_style is not None: | ||
| self.quoting_style = quoting_style | ||
|
|
||
|
|
@@ -1415,6 +1423,28 @@ cdef class WriteOptions(_Weakrefable): | |
| def delimiter(self, value): | ||
| deref(self.options).delimiter = _single_char(value) | ||
|
|
||
| @property | ||
| def eol(self): | ||
| """ | ||
| The end of line character to use for ending rows | ||
| """ | ||
| return frombytes(deref(self.options).eol) | ||
|
|
||
| @eol.setter | ||
| def eol(self, value): | ||
| deref(self.options).eol = tobytes(value) | ||
|
|
||
| @property | ||
| def null_string(self): | ||
| """ | ||
| The string to write for null values. Quotes are not allowed in this string. | ||
| """ | ||
| return frombytes(deref(self.options).null_string) | ||
|
|
||
| @null_string.setter | ||
| def null_string(self, value): | ||
| deref(self.options).null_string = tobytes(value) | ||
|
|
||
| @property | ||
| def quoting_style(self): | ||
| """ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to escape the backslash to render in final doc rather than to break the doc comment.