Skip to content

Conversation

@ryanvo504
Copy link

@ryanvo504 ryanvo504 commented Jul 30, 2025

Rationale for this change

This change improves compilation times and supports C++23 compatibility.

What changes are included in this PR?

Moves constructor, move constructor, move assignment operator, and member function implementations (Find, CreateEntry, AssignEntry, DeleteEntry) from inline definitions in the header to the source file. Also fixes duplicate "public:" access specifier in Entry class.

Are these changes tested?

Are there any user-facing changes?

Closes #47230

@github-actions github-actions bot added the awaiting review Awaiting review label Jul 30, 2025
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@ryanvo504 ryanvo504 changed the title Fixes C++23 compatibility issues GH-47230: [C++] Fixes C++23 compatibility issues Jul 30, 2025
@kou
Copy link
Member

kou commented Aug 5, 2025

We need to work on #47208 before this.

@kou
Copy link
Member

kou commented Aug 14, 2025

Could you rebase on main to use #47261 and #47318 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Move Directory method implementations from header to source file

2 participants