Skip to content

Conversation

@YKoustubhRao
Copy link
Contributor

@YKoustubhRao YKoustubhRao commented Aug 23, 2025

Rationale for this change

Tiny grammar mistake

What changes are included in this PR?

Just the above typo fix

Are these changes tested?

Yes

Are there any user-facing changes?

No

Was just cursing through each file, this typo was bit bugging (not a grammar nazi)
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title Fix grammar typo in visibility.h MINOR: [C++] Fix grammar typo in visibility.h Aug 25, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
Copy link
Member

kou commented Aug 25, 2025

This was introduced by #39067.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 25, 2025
@kou kou merged commit a9cdeaf into apache:main Aug 25, 2025
37 of 42 checks passed
@kou kou removed the awaiting merge Awaiting merge label Aug 25, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a9cdeaf.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

@YKoustubhRao YKoustubhRao deleted the patch-1 branch August 27, 2025 06:48
gitmodimo pushed a commit to gitmodimo/arrow that referenced this pull request Oct 2, 2025
### Rationale for this change

Tiny grammar mistake

### What changes are included in this PR?

Just the above typo fix

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

Authored-by: Koustubh Rao <88176320+YKoustubhRao@users.noreply.github.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants