Skip to content

ARROW-5380: [C++] Fix potential 1nt96 ubsan issue missed first time around #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emkornfield wants to merge 2 commits into from
Closed

ARROW-5380: [C++] Fix potential 1nt96 ubsan issue missed first time around #4787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c82d0ea
ARROW-5380: Fix potential int96 alignment issue
emkornfield Jul 3, 2019
8c240b8
add address
emkornfield Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/parquet/arrow/writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ inline void ArrowTimestampToImpalaTimestamp(const int64_t time, Int96* impala_ti
(*impala_timestamp).value[2] = (uint32_t)julian_days;

int64_t last_day_units = time % UnitPerDay;
int64_t* impala_last_day_nanos = reinterpret_cast<int64_t*>(impala_timestamp);
*impala_last_day_nanos = last_day_units * NanosecondsPerUnit;
int64_t day_nanos = last_day_units * NanosecondsPerUnit;
std::memcpy(impala_timestamp, &day_nanos, sizeof(day_nanos));
}

constexpr int64_t kSecondsInNanos = INT64_C(1000000000);
Expand Down