Skip to content

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented Jul 12, 2019

Take and Filter kernels should now be able to operate on arrays of any type.

@emkornfield emkornfield changed the title ARROW-5594: add UnionArrays support to Take/Filter kernels ARROW-5594: [C++] add UnionArrays support to Take/Filter kernels Jul 20, 2019
@kszucs kszucs force-pushed the master branch 2 times, most recently from ed180da to 85fe336 Compare July 22, 2019 19:29
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bkietz ! Looks good on the principle, just a couple comments and questions.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will merge if green.

@codecov-io
Copy link

Codecov Report

Merging #4866 into master will increase coverage by 1.64%.
The diff coverage is 98.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4866      +/-   ##
==========================================
+ Coverage   87.46%    89.1%   +1.64%     
==========================================
  Files         994      717     -277     
  Lines      140389   100548   -39841     
  Branches     1418        0    -1418     
==========================================
- Hits       122788    89591   -33197     
+ Misses      17239    10957    -6282     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/arrow/compute/kernels/take.cc 97.29% <100%> (-0.62%) ⬇️
cpp/src/arrow/ipc/json-simple-test.cc 100% <100%> (ø) ⬆️
cpp/src/arrow/compute/kernels/take-test.cc 100% <100%> (ø) ⬆️
cpp/src/arrow/compute/kernels/filter.cc 98.03% <100%> (ø) ⬆️
cpp/src/arrow/compute/kernels/filter-test.cc 100% <100%> (ø) ⬆️
cpp/src/arrow/ipc/json-simple.cc 98.38% <100%> (ø) ⬆️
cpp/src/arrow/compute/kernels/take-internal.h 94.67% <97.45%> (+2.77%) ⬆️
cpp/src/arrow/json/converter.cc 90.53% <0%> (-1.78%) ⬇️
cpp/src/arrow/json/chunked-builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/arrow/csv/parser-test.cc 98.61% <0%> (-1.39%) ⬇️
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe336...2e2e589. Read the comment docs.

@pitrou pitrou closed this in bc837e6 Jul 25, 2019
@bkietz bkietz deleted the 5594-add-support-for-UnionArrays-to-Take-and- branch February 25, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants