Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jul 13, 2019

This is follow-up for ARROW-5892: #4835


GGandivaFunctionSignature *ggandiva_native_function_get_signature(GGandivaNativeFunction *native_function);
GList *
ggandiva_native_function_get_signatures(GGandivaNativeFunction *native_function);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we add GARROW_AVAILABLE_IN_1_0 in another pull request after #4841 is merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Copy link
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiro615 shiro615 closed this in f05f647 Jul 15, 2019
@kou kou deleted the glib-gandiva-function-aliases branch July 15, 2019 21:33
kszucs pushed a commit that referenced this pull request Jul 22, 2019
This is follow-up for ARROW-5892: #4835

Author: Sutou Kouhei <kou@clear-code.com>

Closes #4874 from kou/glib-gandiva-function-aliases and squashes the following commits:

306d064 <Sutou Kouhei> Add symbol list for 1.0.0
5f173d6 <Sutou Kouhei>  Add support for function aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants