Skip to content

ARROW-5986: [Java] Code cleanup for dictionary encoding #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianchen92 wants to merge 1 commit into from
Closed

ARROW-5986: [Java] Code cleanup for dictionary encoding #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 0 additions & 117 deletions ...e/src/test/java/org/apache/arrow/vector/dictionary/DictionaryEncodeHashMapBenchmarks.java
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions java/vector/src/main/java/org/apache/arrow/vector/BaseBinaryVector.java
View file
Open in desktop

This file was deleted.

12 changes: 1 addition & 11 deletions java/vector/src/main/java/org/apache/arrow/vector/FixedSizeBinaryVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.vector.complex.impl.FixedSizeBinaryReaderImpl;
import org.apache.arrow.vector.complex.reader.FieldReader;
import org.apache.arrow.vector.dictionary.ByteArrayWrapper;
import org.apache.arrow.vector.holders.FixedSizeBinaryHolder;
import org.apache.arrow.vector.holders.NullableFixedSizeBinaryHolder;
import org.apache.arrow.vector.types.Types.MinorType;
Expand All @@ -38,7 +37,7 @@
* binary values which could be null. A validity buffer (bit vector) is
* maintained to track which elements in the vector are null.
*/
public class FixedSizeBinaryVector extends BaseFixedWidthVector implements BaseBinaryVector {
public class FixedSizeBinaryVector extends BaseFixedWidthVector {
private final int byteWidth;
private final FieldReader reader;

Expand Down Expand Up @@ -364,15 +363,6 @@ public TransferPair makeTransferPair(ValueVector to) {
return new TransferImpl((FixedSizeBinaryVector) to);
}

@Override
public ByteArrayWrapper getByteArrayWrapper(int index) {
if (isNull(index)) {
return null;
} else {
return new ByteArrayWrapper(getObject(index));
}
}

private class TransferImpl implements TransferPair {
FixedSizeBinaryVector to;

Expand Down
12 changes: 1 addition & 11 deletions java/vector/src/main/java/org/apache/arrow/vector/VarBinaryVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.vector.complex.impl.VarBinaryReaderImpl;
import org.apache.arrow.vector.complex.reader.FieldReader;
import org.apache.arrow.vector.dictionary.ByteArrayWrapper;
import org.apache.arrow.vector.holders.NullableVarBinaryHolder;
import org.apache.arrow.vector.holders.VarBinaryHolder;
import org.apache.arrow.vector.types.Types.MinorType;
Expand All @@ -35,7 +34,7 @@
* values which could be NULL. A validity buffer (bit vector) is maintained
* to track which elements in the vector are null.
*/
public class VarBinaryVector extends BaseVariableWidthVector implements BaseBinaryVector {
public class VarBinaryVector extends BaseVariableWidthVector {
private final FieldReader reader;

/**
Expand Down Expand Up @@ -280,15 +279,6 @@ public TransferPair makeTransferPair(ValueVector to) {
return new TransferImpl((VarBinaryVector) to);
}

@Override
public ByteArrayWrapper getByteArrayWrapper(int index) {
if (isNull(index)) {
return null;
} else {
return new ByteArrayWrapper(getObject(index));
}
}

private class TransferImpl implements TransferPair {
VarBinaryVector to;

Expand Down
Loading