ARROW-6329: [Format] Add a padding for Flatbuffer alignment, use 8-byte EOS #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4951 +/- ##
==========================================
- Coverage 87.33% 64.74% -22.6%
==========================================
Files 895 491 -404
Lines 119946 65572 -54374
Branches 1418 0 -1418
==========================================
- Hits 104751 42452 -62299
- Misses 14833 23120 +8287
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
pitrou
reviewed
Jul 29, 2019
docs/source/format/IPC.rst
Outdated
| @@ -24,13 +24,16 @@ Encapsulated message format | |||
| Data components in the stream and file formats are represented as encapsulated | |||
| *messages* consisting of: | |||
|
|
|||
| * A 32-bit continuation indicator (0xFFFFFFFF). This allows flatbuffer bytes | |||
| to begin on an 8-byte boundary. This was added as of release 0.15.0. | |||
| * A length prefix indicating the metadata size | |||
Member
There was a problem hiding this comment.
Change this to "A 32-bit length prefix"?
(also, where is endianness documented?)
Contributor
Author
There was a problem hiding this comment.
Changed. Also clarified it is little endian.
Member
|
I added some additional clarification. I'm going to start a vote on the mailing list |
pitrou
reviewed
Aug 7, 2019
wesm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion on the mailing list.