Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche
Copy link
Member Author

As noted on the issue, I could also add a safe=True/False keyword similarly to DictionaryArray.from_arrays.

@codecov-io
Copy link

Codecov Report

Merging #5029 into master will decrease coverage by 22.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5029       +/-   ##
===========================================
- Coverage   87.32%   65.18%   -22.14%     
===========================================
  Files         895      492      -403     
  Lines      119946    65894    -54052     
  Branches     1418        0     -1418     
===========================================
- Hits       104748    42956    -61792     
- Misses      14836    22938     +8102     
+ Partials      362        0      -362
Impacted Files Coverage Δ
python/pyarrow/array.pxi 79.69% <100%> (ø)
python/pyarrow/tests/test_array.py 96.35% <100%> (ø)
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/util-internal.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
... and 887 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0423a...5fe476e. Read the comment docs.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@pitrou pitrou closed this in 3e6d75b Aug 8, 2019
@jorisvandenbossche jorisvandenbossche deleted the ARROW-6132-from_arrays-check-validity branch August 8, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants