ARROW-6250: [Java] Implement ApproxEqualsVisitor comparing approx for floating point #5118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @pravindra |
pravindra
reviewed
Aug 20, 2019
java/vector/src/main/java/org/apache/arrow/vector/compare/ApproxEqualsVisitor.java
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/compare/ApproxEqualsVisitor.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5118 +/- ##
=========================================
Coverage ? 89.73%
=========================================
Files ? 674
Lines ? 101447
Branches ? 0
=========================================
Hits ? 91035
Misses ? 10412
Partials ? 0Continue to review full report at Codecov.
|
Contributor
Author
|
@pravindra I updated this PR, please help take a look when you have time, thanks! |
pravindra
approved these changes
Aug 21, 2019
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
… floating point Related to [ARROW-6250](https://issues.apache.org/jira/browse/ARROW-6250). Currently we already implemented RangeEqualsVisitor/VectorEqualsVisitor for comparing range/vector. And ARROW-6211 is created to make ValueVector work with generic visitor. We should also implement ApproxEqualsVisitor to compare floating point just like cpp does https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc Closes apache#5118 from tianchen92/ARROW-6250 and squashes the following commits: 43ff57e <tianchen> approx equals support complex type 01c5c85 <tianchen> ARROW-6250: Implement ApproxEqualsVisitor comparing approx for floating point Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6250.
Currently we already implemented RangeEqualsVisitor/VectorEqualsVisitor for comparing range/vector.
And ARROW-6211 is created to make ValueVector work with generic visitor.
We should also implement ApproxEqualsVisitor to compare floating point just like cpp does
https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc