ARROW-6288: [Java] Implement TypeEqualsVisitor comparing vector type equals considering names and metadata #5119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equals considering names and metadata
Contributor
Author
|
cc @pravindra |
pravindra
reviewed
Aug 20, 2019
| compareChilren(leftField.getChildren(), rightField.getChildren()); | ||
| } | ||
|
|
||
| private boolean compareChilren(List<Field> leftChildren, List<Field> rightChildren) { |
Contributor
There was a problem hiding this comment.
typo - compareChilren -> compareChildren
| return compareField(left.getField(), right.getField()); | ||
| } | ||
|
|
||
| private boolean compareField(Field leftField, Field rightField) { |
Contributor
There was a problem hiding this comment.
add a fastpath for leftField == rightField ?
| } | ||
|
|
||
| @Test | ||
| public void testTypeEqualsWithMetadate() { |
Contributor
There was a problem hiding this comment.
typo : Metadate -> Metadata
pravindra
approved these changes
Aug 20, 2019
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…equals considering names and metadata Related to [ARROW-6288](https://issues.apache.org/jira/browse/ARROW-6288). Currently when we compare range/vector equals, we first compare vector Field by its equals method, in this case, it’s hard to specify whether compare names or metadata. Implement a TypeEqualsVisitor will make type comparisons more flexible like cpp implementation dose https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc#L712 Closes apache#5119 from tianchen92/ARROW-6288 and squashes the following commits: fa4975f <tianchen> resolve comments 425a849 <tianchen> ARROW-6288: Implement TypeEqualsVisitor comparing vector type equals considering names and metadata Authored-by: tianchen <niki.lj@alibaba-inc.com> Signed-off-by: Wes McKinney <wesm+git@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6288.
Currently when we compare range/vector equals, we first compare vector Field by its equals method, in this case, it’s hard to specify whether compare names or metadata.
Implement a TypeEqualsVisitor will make type comparisons more flexible like cpp implementation dose https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc#L712