Skip to content

Conversation

@michaelmaguire
Copy link

@michaelmaguire michaelmaguire commented Aug 19, 2019

https://issues.apache.org/jira/browse/ARROW-6312

These are the Libs.private I needed in order to get my in-house static build working

These are the Libs.private I needed in order to get my in-house *static* build working
@kou
Copy link
Member

kou commented Aug 19, 2019

Could you open an issue on JIRA https://issues.apache.org/jira/projects/ARROW/issues and prepend "ARROW-${JIRA_ISSUE_ID}: [C++] " to the subject of this pull request?

https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches

And could you also provide information how to reproduce your problem?

This patch isn't acceptable because some people build Apache Arrow C++ without Snappy, zlib and so on.

@codecov-io
Copy link

Codecov Report

Merging #5123 into master will increase coverage by 17.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5123       +/-   ##
===========================================
+ Coverage   72.12%   89.24%   +17.11%     
===========================================
  Files         835      731      -104     
  Lines      111553   105048     -6505     
  Branches     1437        0     -1437     
===========================================
+ Hits        80457    93746    +13289     
+ Misses      30734    11302    -19432     
+ Partials      362        0      -362
Impacted Files Coverage Δ
cpp/src/arrow/testing/gtest_util.h 97.36% <0%> (-2.64%) ⬇️
cpp/src/arrow/compute/kernel.h 61.16% <0%> (-1.53%) ⬇️
cpp/src/arrow/result.h 91.3% <0%> (-0.37%) ⬇️
cpp/src/arrow/table.h 100% <0%> (ø) ⬆️
cpp/src/arrow/flight/server.h 100% <0%> (ø) ⬆️
cpp/src/arrow/table_builder.h 100% <0%> (ø) ⬆️
cpp/src/plasma/plasma.h 100% <0%> (ø) ⬆️
cpp/src/gandiva/configuration.h 100% <0%> (ø) ⬆️
cpp/src/arrow/csv/column_builder.h 100% <0%> (ø) ⬆️
cpp/src/arrow/compute/kernels/cast.h 100% <0%> (ø) ⬆️
... and 703 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b476...74684f3. Read the comment docs.

@michaelmaguire michaelmaguire changed the title Declare other required Libs.private to aid in static linking ARROW-6312: [C++] Declare other required Libs.private to aid in static linking Aug 21, 2019
@michaelmaguire
Copy link
Author

Could you open an issue on JIRA https://issues.apache.org/jira/projects/ARROW/issues and prepend "ARROW-${JIRA_ISSUE_ID}: [C++] " to the subject of this pull request?

Done!

@emkornfield
Copy link
Contributor

@michaelmaguire thanks for creating the JIRA and updating the title, it doesn't look like you addressed @kou concerns about dynamically generating the dependencies.

@michaelmaguire
Copy link
Author

@michaelmaguire thanks for creating the JIRA and updating the title, it doesn't look like you addressed @kou concerns about dynamically generating the dependencies.

That is correct. My proposed PR was considered unsuitable. I'm happy to have raised awareness of the issue, I'm sorry I don't have time to address the problem in a way deemed suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants