ARROW-4095: [C++] Optimize DictionaryArray::Transpose() for trivial transpositions #5230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
changed the title
pitrou
force-pushed
the
ARROW-4095-dictarray-transpose-optimization
branch
from
8cad473 to
96c6cd6
Compare
pitrou
changed the title
…ranspositions Note this doesn't handle the case of a trivial transposition but where the index type changes.
pitrou
force-pushed
the
ARROW-4095-dictarray-transpose-optimization
branch
from
96c6cd6 to
acae5e0
Compare
fsaintjacques
approved these changes
Aug 30, 2019
Contributor
fsaintjacques
left a comment
fsaintjacques
left a comment
There was a problem hiding this comment.
LGTM, will wait for AppVeyor.
Contributor
|
Appveyor passed. going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this doesn't optimize the case of a trivial transposition but where the index type changes.
Also fix handling of sliced arrays, and add tests.