Skip to content

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented Aug 29, 2019

Adds explicit not that null slots should be interpreted as an unknown.

The boolean and compare kernels do not currently implement this behavior:
And(null, false) -> null
Compare(GREATER_EQUAL, null, 0U) -> null

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@53384de). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5231   +/-   ##
=========================================
  Coverage          ?   65.29%           
=========================================
  Files             ?      497           
  Lines             ?    67538           
  Branches          ?        0           
=========================================
  Hits              ?    44099           
  Misses            ?    23439           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53384de...666d182. Read the comment docs.

@fsaintjacques fsaintjacques changed the title ARROW-6386: [C++][Documentation] add documentation on interpretation of null slots ARROW-6386: [C++][Documentation] Add documentation on interpretation of null slots Aug 30, 2019
@wesm
Copy link
Member

wesm commented Sep 4, 2019

I'm not sure about this. The specification documents don't provide any guidance about computational semantics, only data representation. It is stated elsewhere (I believe?) that the values "underneath" null slots are not defined.

@wesm
Copy link
Member

wesm commented Sep 10, 2019

-1. The spec says "Array slots which are null are not required to have a particular value"; I do not think we need to say more on the matter

@wesm wesm closed this Sep 10, 2019
@bkietz bkietz deleted the 6386-Documentation-Explicit-do branch February 25, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants