Skip to content

Conversation

@emkornfield
Copy link
Contributor

@emkornfield emkornfield commented Sep 4, 2019

  • Updates testing module to point to latest master which contains files
  • Refactors integration tests:
    • Move skips to use the build in skip functionality
    • generalize compare_implementation to a take a function to run tests

We could potentially provide more metadata as part of the checked in files, as this change relies a little too much on file name convention, but it does the jobs.

@emkornfield
Copy link
Contributor Author

Personal travis CI run: https://travis-ci.org/emkornfield/arrow/jobs/580759660

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d818299). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5272   +/-   ##
=========================================
  Coverage          ?   89.07%           
=========================================
  Files             ?      885           
  Lines             ?   119797           
  Branches          ?     1437           
=========================================
  Hits              ?   106715           
  Misses            ?    12720           
  Partials          ?      362

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d818299...3c7d6f7. Read the comment docs.

@wesm
Copy link
Member

wesm commented Sep 5, 2019

Cool, looks good to me. We need to remove the use of --gold_dirs from the integration test Travis script before merging

@emkornfield
Copy link
Contributor Author

We need to remove the use of --gold_dirs from the integration test Travis script before merging

Don't we want to run this as part of travis? Could you elaborate?

@wesm
Copy link
Member

wesm commented Sep 5, 2019

I see, I thought this parameter was exclusive with the endogenous tests.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I think soon we should refactor integration_test.py into a small Python package

@wesm
Copy link
Member

wesm commented Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants