Skip to content

ARROW-6447: [C++] Allow rest of arrow_objlib to build in parallel while memory_pool.cc is waiting on jemalloc_ep #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 3 commits into from
Closed

ARROW-6447: [C++] Allow rest of arrow_objlib to build in parallel while memory_pool.cc is waiting on jemalloc_ep #5281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb52965
Add jemalloc_ep dependency only on memory_pool.cc
wesm Sep 4, 2019
c93f311
cmake-format
wesm Sep 4, 2019
7e46ff4
Only use OBJECT_DEPENDS with Ninja build generator
wesm Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,7 +1406,6 @@ if(ARROW_JEMALLOC)
INTERFACE_INCLUDE_DIRECTORIES
"${CMAKE_CURRENT_BINARY_DIR}/jemalloc_ep-prefix/src")
add_dependencies(jemalloc::jemalloc jemalloc_ep)
add_dependencies(toolchain jemalloc_ep)
endif()

# ----------------------------------------------------------------------
Expand Down
12 changes: 8 additions & 4 deletions cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@ set(ARROW_SRCS
util/utf8.cc
vendored/datetime/tz.cpp)

if(ARROW_JEMALLOC)
if("${CMAKE_GENERATOR}" STREQUAL "Ninja")
set_source_files_properties(memory_pool.cc PROPERTIES OBJECT_DEPENDS jemalloc_ep)
else()
add_dependencies(arrow_dependencies jemalloc_ep)
endif()
endif()

if(ARROW_JSON)
add_subdirectory(json)
set(ARROW_SRCS
Expand Down Expand Up @@ -205,10 +213,6 @@ if(ARROW_CUDA)
add_subdirectory(gpu)
endif()

if(ARROW_JEMALLOC AND JEMALLOC_VENDORED)
add_dependencies(arrow_dependencies jemalloc::jemalloc)
endif()

if(ARROW_WITH_BROTLI)
add_definitions(-DARROW_WITH_BROTLI)
set(ARROW_SRCS util/compression_brotli.cc ${ARROW_SRCS})
Expand Down