Skip to content

ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file#5502

Closed
alippai wants to merge 1 commit intoapache:masterfrom
alippai:patch-2
Closed

ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file#5502
alippai wants to merge 1 commit intoapache:masterfrom
alippai:patch-2

Conversation

@alippai
Copy link
Copy Markdown
Contributor

@alippai alippai commented Sep 25, 2019

No description provided.

Comment thread rust/datafusion/tests/sql.rs Outdated
@andygrove
Copy link
Copy Markdown
Member

@alippai Could you remove the parquet-testing submodule changes from this PR please.

Once the PR against the parquet-testing repo is merged, we can merge this one.

@andygrove andygrove changed the title ARROW-6687: [Rust] Add regression tests for the new datafusion .parqu… ARROW-6687: [Rust] [DataFusion] Add regression tests for np.nan parquet file Sep 26, 2019
@alippai
Copy link
Copy Markdown
Contributor Author

alippai commented Sep 26, 2019

@andygrove changed the commit id in the parquet-testing to the merged one. This PR rolls the git submodule "version" (in order to see the changes in parquet-testing).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 28, 2019

Codecov Report

Merging #5502 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5502      +/-   ##
==========================================
+ Coverage   88.66%   89.21%   +0.54%     
==========================================
  Files         965      773     -192     
  Lines      128533   113051   -15482     
  Branches     1501        0    -1501     
==========================================
- Hits       113964   100855   -13109     
+ Misses      14204    12196    -2008     
+ Partials      365        0     -365
Impacted Files Coverage Δ
cpp/src/arrow/json/converter.cc 90.05% <0%> (-1.76%) ⬇️
cpp/src/arrow/json/chunked_builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
cpp/src/arrow/util/thread_pool_test.cc 97.66% <0%> (-0.94%) ⬇️
python/pyarrow/tests/test_parquet.py 95.44% <0%> (-0.12%) ⬇️
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb6b75...136087f. Read the comment docs.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@paddyhoran paddyhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alippai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants