Skip to content

ARROW-836: add test for pandas conversion of timedelta, currently unimplemented #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback wants to merge 1 commit into from
Closed

ARROW-836: add test for pandas conversion of timedelta, currently unimplemented #551

jreback wants to merge 1 commit into from
+23 −0

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Apr 16, 2017

@jreback
Copy link
Contributor Author

jreback commented Apr 16, 2017

so looks like this type should be added. The impl should be almost exactly like TimestampType (but no need for timezones). and the units would be exactly the same as supported by Timestamps.

@wesm
Copy link
Member

wesm commented Apr 16, 2017

Agreed -- we have a SQL-compliant "interval" type (https://github.com/apache/arrow/blob/master/format/Schema.fbs#L143), but no absolute timedelta. The implementation would be the same as Time (https://github.com/apache/arrow/blob/master/format/Schema.fbs#L106), though perhaps we can relax the storage constraint and use 64 bits for everything.

Would you mind opening a JIRA and prefixing the PR title with ARROW-XXX:? thanks @jreback !

@jreback
Copy link
Contributor Author

jreback commented Apr 16, 2017

yes I think the current definition of IntervalType is not going to work here; that looks for year/months.

@jreback
Copy link
Contributor Author

jreback commented Apr 16, 2017

https://issues.apache.org/jira/browse/ARROW-835

@wesm
Copy link
Member

wesm commented Apr 16, 2017

Cool, as a bookkeeping matter can you also make a JIRA for this patch and update the PR title? https://github.com/apache/arrow#how-to-contribute

@jreback jreback changed the title TST: add test for pandas conversion of timedelta, currently unimplemented ARROW-836: add test for pandas conversion of timedelta, currently unimplemented Apr 16, 2017
@jreback
Copy link
Contributor Author

jreback commented Apr 16, 2017

done: https://issues.apache.org/jira/browse/ARROW-836

wesm
wesm approved these changes Apr 16, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 09e6ead Apr 16, 2017
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
@jreback @jeffknupp
ARROW-836: add test for pandas conversion of timedelta, currently uni…
9b8750d 
…mplemented

xref pandas-dev/pandas#16004

Author: Jeff Reback <jeff.reback@twosigma.com>

Closes apache#551 from jreback/timedelta and squashes the following commits:

cfd310e [Jeff Reback] TST: add test for pandas conversion of timedelta, currently unimplemented
This was referenced Feb 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jreback @wesm