Skip to content

ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Array slice #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nealrichardson wants to merge 3 commits into from
Closed

ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Array slice #5570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96220d1
Test and fix for bug in filter kernel with a slice
nealrichardson Oct 2, 2019
f7e9475
lint
nealrichardson Oct 2, 2019
3a772fc
Lint again
nealrichardson Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cpp/src/arrow/compute/kernels/filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,8 @@ class FilterIndexSequence {

// TODO(bkietz) this can be optimized
static int64_t OutputSize(const BooleanArray& filter) {
auto offset = filter.offset();
auto length = filter.length();
int64_t size = 0;
for (auto i = offset; i < offset + length; ++i) {
for (auto i = 0; i < filter.length(); ++i) {
if (filter.IsNull(i) || filter.Value(i)) {
++size;
}
Expand Down
4 changes: 4 additions & 0 deletions cpp/src/arrow/compute/kernels/filter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ TYPED_TEST(TestFilterKernelWithNumeric, FilterNumeric) {
this->AssertFilter("[7, 8, 9]", "[null, 1, 0]", "[null, 8]");
this->AssertFilter("[7, 8, 9]", "[1, null, 1]", "[7, null, 9]");

this->AssertFilterArrays(ArrayFromJSON(this->type_singleton(), "[7, 8, 9]"),
ArrayFromJSON(boolean(), "[0, 1, 1, 1, 0, 1]")->Slice(3, 3),
ArrayFromJSON(this->type_singleton(), "[7, 9]"));

std::shared_ptr<Array> arr;
ASSERT_RAISES(Invalid, this->Filter(this->type_singleton(), "[7, 8, 9]", "[]", &arr));
}
Expand Down