Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 12, 2019

It checks pull request title periodically.

If a checked pull request doesn't start with ARROW-XXX, github-actions bot comments how to contribute.

See .github/workflows/pull_request/title_check.md for comment content.

@kou
Copy link
Member Author

kou commented Oct 12, 2019

Demo: kou#6

@github-actions
Copy link

@kou kou force-pushed the developer-check-pull-request-title branch from ac259c0 to 6993266 Compare October 13, 2019 23:17
@kou kou force-pushed the developer-check-pull-request-title branch from 6993266 to db1a95f Compare October 13, 2019 23:34
@wesm
Copy link
Member

wesm commented Oct 14, 2019

What do you think about permitting PRs with [MINOR] or similar to not have a JIRA? It's not that much of a nuisance to have the bot commenting on minor PRs, though

@wesm
Copy link
Member

wesm commented Oct 14, 2019

(very cool by the way)

@kou
Copy link
Member Author

kou commented Oct 14, 2019

I think that indicating "no JIRA pull request" by title is fragile. We need to add a rule to our how to contribute guideline. We may forget the new rule.

In this change, the check doesn't comment a pull request that already has any comments:
https://github.com/apache/arrow/pull/5628/files#diff-3cbfc93b2e63cf9e17728203104d36a0R53

It means that we can prevent "open an issue on JIRA" comment by just commenting "This is a trivial fix." by ourselves like #5604 (review) .

I think that this is simpler and easy to understand the situation of the pull request.
What do you think about this approach?

@kou
Copy link
Member Author

kou commented Oct 14, 2019

I think that Travis CI failure is unrelated.

@kou
Copy link
Member Author

kou commented Oct 16, 2019

No more comments?
I'll merge this tomorrow.

@kou
Copy link
Member Author

kou commented Oct 16, 2019

I'll merge this.

@kou kou closed this in d7d26c9 Oct 17, 2019
@wesm
Copy link
Member

wesm commented Oct 17, 2019

Thanks @kou (I agree, trivial fixes are rare enough that it is not a big deal)

@kou kou deleted the developer-check-pull-request-title branch November 5, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants