ARROW-6964: [C++][Dataset] Add multithread support to Scanner::ToTable #5721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsaintjacques
commented
Oct 23, 2019
cpp/src/arrow/dataset/scanner.cc
Outdated
Contributor
Author
There was a problem hiding this comment.
I prefer the explicit loop than nested Visitor.
fsaintjacques
commented
Oct 23, 2019
cpp/src/arrow/dataset/scanner.h
Outdated
Contributor
Author
There was a problem hiding this comment.
Maybe it's time to expose a common ResourceContext class that has a MemoryPool and a ThreadPool?
pitrou
reviewed
Oct 24, 2019
cpp/src/arrow/dataset/scanner.cc
Outdated
Member
There was a problem hiding this comment.
I don't think it's useful to make this inline.
bkietz
requested changes
Oct 24, 2019
cpp/src/arrow/dataset/scanner.h
Outdated
Member
There was a problem hiding this comment.
Maybe this should be a task group instead of a thread pool. Then users can pass a serial task group to signal single threaded operation
cpp/src/arrow/dataset/scanner.cc
Outdated
Member
There was a problem hiding this comment.
Suggested change
| batches.emplace_back(batch); | |
| batches.emplace_back(std::move(batch)); |
fsaintjacques
force-pushed
the
ARROW-6964-parallel-scanner-to-table
branch
from
8d6e72e to
10ed013
Compare
The caller may request a parallel construction of the table. Scanner was refactor to own the ScanOptions and ScanContext members. The `use_threads` options was added to ScanOptions so the caller can indicate if Scanner is allowed to use parallelism.
fsaintjacques
force-pushed
the
ARROW-6964-parallel-scanner-to-table
branch
from
10ed013 to
210f190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caller may request a parallel construction of the table. Scanner was refactored to own the ScanOptions and ScanContext members.