ARROW-7268: [Rust] Add custom_metadata field from IPC message to Schema.
#5907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundprinzip
changed the title
custom_metadata field from IPC message to Schema.custom_metadata field from IPC message to Schema.
grundprinzip
force-pushed
the
schema_metadata
branch
from
99c59d2 to
d2ab7e6
Compare
nevi-me
reviewed
Nov 27, 2019
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
Hi @grundprinzip, one minor comment on a private function name
…hema. This patch propagates the `custom_metadata` field from the IPC message to the Schema type. It adds the necessary serailization and deserialization logic and tests.
grundprinzip
force-pushed
the
schema_metadata
branch
from
d2ab7e6 to
8229284
Compare
paddyhoran
approved these changes
Nov 27, 2019
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
LGTM, thanks @grundprinzip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch propagates the
custom_metadatafield from the IPC messageto the Schema type. It adds the necessary serailization and
deserialization logic and tests.