-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-7644: [Doc][Install] Add vcpkg installation instructions #6252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
|
||
| .. _building-vcpkg: | ||
|
|
||
| Building with Vcpkg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this description describes how to install Apache Arrow C++ with vcpkg instead of describing how tobuild with vcpkg.
How about adding this to https://github.com/apache/arrow-site/blob/master/install.md ? The file is published as https://arrow.apache.org/install/ .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, I will move it to that doc.
|
BTW, are you interested in adding Apache Arrow GLib package to vcpkg too?
|
|
@kou According to our documentation, we tend to use cmake to build ports, because the port dependencies in vcpkg are mostly guaranteed by cmake. |
|
vcpkg has Meson support: https://github.com/microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_install_meson.cmake |
|
@kou Yes, we can try to use Meson, but because there are many libraries based on these ports, we need to deal with the correlation issues. |
|
Great!
I think so too. I did one of them: microsoft/vcpkg#8162 Could you help us for it? |
|
@kou Maybe you can submit a PR as the beginning and let us handle it :) |
|
OK! |
|
I've create a PR #42 in arrow-site. |
arrow is available as a port in vcpkg, a C++ library manager that simplifies installation for arrow and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build arrow, ready to be included in their projects.
We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64, UWP, ARM) to keep a wide coverage for users.
I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.