Skip to content

ARROW-7719: [Python][Dataset] Table equality check occasionally fails #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kszucs wants to merge 1 commit into from
Closed

ARROW-7719: [Python][Dataset] Table equality check occasionally fails #6319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions python/pyarrow/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,19 +567,19 @@ def _check_dataset_from_path(path, table, **kwargs):
assert isinstance(path, pathlib.Path)
dataset = ds.dataset(ds.source(path, **kwargs))
assert dataset.schema.equals(table.schema, check_metadata=False)
result = dataset.to_table()
result = dataset.to_table(use_threads=False) # deterministic row order
assert result.replace_schema_metadata().equals(table)

# string path
dataset = ds.dataset(ds.source(str(path), **kwargs))
assert dataset.schema.equals(table.schema, check_metadata=False)
result = dataset.to_table()
result = dataset.to_table(use_threads=False) # deterministic row order
assert result.replace_schema_metadata().equals(table)

# passing directly to dataset
dataset = ds.dataset(str(path), **kwargs)
assert dataset.schema.equals(table.schema, check_metadata=False)
result = dataset.to_table()
result = dataset.to_table(use_threads=False) # deterministic row order
assert result.replace_schema_metadata().equals(table)


Expand Down Expand Up @@ -607,7 +607,7 @@ def test_open_dataset_list_of_files(tempdir):
ds.dataset(ds.source([path1, path2])),
ds.dataset(ds.source([str(path1), str(path2)]))]:
assert dataset.schema.equals(table.schema, check_metadata=False)
result = dataset.to_table()
result = dataset.to_table(use_threads=False) # deterministic row order
assert result.replace_schema_metadata().equals(table)


Expand Down Expand Up @@ -643,7 +643,7 @@ def test_open_dataset_partitioned_directory(tempdir):
expected_schema = table.schema.append(pa.field("part", pa.int8()))
assert dataset.schema.equals(expected_schema, check_metadata=False)

result = dataset.to_table()
result = dataset.to_table(use_threads=False)
expected = full_table.append_column(
"part", pa.array(np.repeat([0, 1, 2], 9), type=pa.int8()))
assert result.replace_schema_metadata().equals(expected)
Expand Down