Skip to content

ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 3 commits into from
Closed

ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build #6325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d570649
ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build
pitrou Jan 30, 2020
eb5db8f
Try a more flexible way of finding Boost
pitrou Feb 3, 2020
e877622
Revert "Try a more flexible way of finding Boost"
pitrou Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,15 @@ jobs:
ARROW_BUILD_STATIC: OFF
ARROW_BOOST_USE_SHARED: OFF
ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
BOOST_SOURCE: BUNDLED
BOOST_ROOT: C:\local\boost_1_67_0
BOOST_LIBRARYDIR: C:\local\boost_1_67_0\lib64-msvc-14.1\
Copy link
Member

@kou kou Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this when boost-msvc-14.1 is updated?
Can we detect this automatically?

Does this work?

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index abc3b8f4d..4cccbdfd0 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -185,7 +185,11 @@ jobs:
           submodules: true
       - name: Build
         shell: bash
-        run: ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+        run: |
+          boost_root="$(echo /c/local/boost_* | head -n1)"
+          export BOOST_ROOT="c:\\local\\$(dirname ${boost_root})"
+          export BOOST_LIBRARYDIR="${BOOST_ROOT}\\lib64-msvc-14.1"
+          ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
       - name: Test
         shell: bash
         run: ci/scripts/cpp_test.sh $(pwd) $(pwd)/build

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'll try it :-)

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this:

  export BOOST_ROOT="$(ls -1 /c/local/boost_* | tail -n1)"
  export BOOST_LIBRARYDIR="${BOOST_ROOT}\\lib64-msvc-14.1"
  echo "BOOST_ROOT: ${BOOST_ROOT}"

and I got:

BOOST_ROOT: tools

:-O

I don't want to spend time debugging this (especially as Github Actions seems a bit slow today), so I'm gonna revert the change.

Copy link
Member

@kou kou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll take it over as a follow-up task.

steps:
- name: Disable Crash Dialogs
run: reg add "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" /v DontShowUI /t REG_DWORD /d 1 /f
- name: Installed Packages
run: choco list -l
Copy link
Member

@kou kou Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this step?

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful to have system info in CI builds.

- name: Install Boost
run: choco install -y boost-msvc-14.1
- name: Checkout Arrow
uses: actions/checkout@v1
with:
Expand Down