ARROW-7913: [C++][Python][R] C++ implementation of C data interface #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
Author
|
Should I add extension type support in this PR or open a JIRA to do it later? |
Member
|
For me, I'm fine with a followup. Think we'll also need a followup to handle ChunkedArray and Table anyway, IIRC. |
bkietz
requested changes
Feb 25, 2020
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Lots of comments:
ci/docker/linux-apt-r.dockerfile
Outdated
| @@ -63,6 +67,18 @@ COPY ci/scripts/r_deps.sh /arrow/ci/scripts/ | |||
| COPY r/DESCRIPTION /arrow/r/ | |||
| RUN /arrow/ci/scripts/r_deps.sh /arrow | |||
|
|
|||
| # Set up Python 3 and its dependencies | |||
| RUN ln -s /usr/bin/python3 /usr/local/bin/python && \ | |||
Member
There was a problem hiding this comment.
Should this be a call to update-alternatives or so?
Member
Author
There was a problem hiding this comment.
I have no idea. At least I don't see a /etc/alternatives/python on Ubuntu.
cpp/src/arrow/c/bridge.cc
Outdated
| return Status::OK(); | ||
| } | ||
|
|
||
| Status ImportNullBitmap(int32_t buffer_id = 0) { |
Member
There was a problem hiding this comment.
Suggested change
| Status ImportNullBitmap(int32_t buffer_id = 0) { | |
| Status ImportNullBitmap() { |
python/pyarrow/cffi.py
Outdated
| }; | ||
| """ | ||
|
|
||
| # TODO use out-of-line mode for faster import and avoid C parsing |
Member
There was a problem hiding this comment.
Suggested change
| # TODO use out-of-line mode for faster import and avoid C parsing | |
| # TODO(pitrou) use out-of-line mode for faster import and avoid C parsing |
bkietz
requested changes
Feb 25, 2020
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Lots of comments:
pitrou
force-pushed
the
ARROW-7913-c-data-interface-impl
branch
5 times, most recently
from
c2606d6 to
c4e3551
Compare
Member
Author
|
Rebasing. |
pitrou
force-pushed
the
ARROW-7913-c-data-interface-impl
branch
from
c4e3551 to
d18ec1d
Compare
Member
|
CI is green; I'd like to merge now. @bkietz do you consent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.