ARROW-7048: [Java] Support for combining multiple vectors under VectorSchemaRoot #6496
+244
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TheNeuralBit do you have time to review? |
emkornfield
reviewed
Mar 4, 2020
| } | ||
|
|
||
| // create type checkers, if necessary | ||
| TypeEqualsVisitor[] typeCheckers = new TypeEqualsVisitor[targetRoot.getFieldVectors().size()]; |
Contributor
There was a problem hiding this comment.
maybe only allocate this is checkSchema = true?
Contributor
Author
There was a problem hiding this comment.
Revised. Thank you for the good suggestion.
Contributor
|
LGTM, one small comment, thanks @liyafan82 |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…rSchemaRoot For details, please see https://issues.apache.org/jira/browse/ARROW-7048 Closes apache#6496 from liyafan82/fly_0227_bat and squashes the following commits: 0aec819 <liyafan82> Avoid creating type checker array unnecessarily 08ff133 <liyafan82> Support for combining multiple vectors under VectorSchemaRoot Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, please see https://issues.apache.org/jira/browse/ARROW-7048