-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-7878: [C++][Compute] Draft LogicalPlan classes #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fsaintjacques
wants to merge
21
commits into
apache:master
from
fsaintjacques:ARROW-7878-logical-plan
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
93398c3
Draft engine component
fsaintjacques a3d5c67
update
fsaintjacques 8691ace
Update
fsaintjacques 77c5bf9
Add key in Catalog::Entry
fsaintjacques 1b59312
Update
fsaintjacques 92bf425
Add projection operator
fsaintjacques 8ea5ddd
Removes Table support from Catalog::Entry
fsaintjacques 8b47016
Add more comment
fsaintjacques 236ff3c
Move compare enums into a single enum
fsaintjacques 52d5a9b
FieldRef should preserve the input
fsaintjacques 7d78abe
Add explicit libarrow_engine.so
fsaintjacques 6fbac47
Fix msvc
fsaintjacques 4a47809
Add custom ARROW_EN_EXPORT for engine
fsaintjacques 5679f83
Fix constant type
fsaintjacques a9fc553
Make msvc happy
fsaintjacques f35c500
Make inner class exportable
fsaintjacques 369af82
Try msvc
fsaintjacques 0423241
Add Aggregate operators with Count and Sum
fsaintjacques 24675c6
Add Compare expressions to LogicalPlanBuilder
fsaintjacques ef10404
Add missing forward
fsaintjacques cf58f34
Add IsA<Expr>
fsaintjacques File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # - Find Arrow Query Engine (arrow/engine/api.h, libarrow_engine.a, libarrow_engine.so) | ||
| # | ||
| # This module requires Arrow from which it uses | ||
| # arrow_find_package() | ||
| # | ||
| # This module defines | ||
| # ARROW_ENGINE_FOUND, whether Arrow Query Engine has been found | ||
| # ARROW_ENGINE_IMPORT_LIB, | ||
| # path to libarrow_engine's import library (Windows only) | ||
| # ARROW_ENGINE_INCLUDE_DIR, directory containing headers | ||
| # ARROW_ENGINE_LIB_DIR, directory containing Arrow Query Engine libraries | ||
| # ARROW_ENGINE_SHARED_LIB, path to libarrow_engine's shared library | ||
| # ARROW_ENGINE_STATIC_LIB, path to libarrow_engine.a | ||
|
|
||
| if(DEFINED ARROW_ENGINE_FOUND) | ||
| return() | ||
| endif() | ||
|
|
||
| set(find_package_arguments) | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_VERSION) | ||
| list(APPEND find_package_arguments | ||
| "${${CMAKE_FIND_PACKAGE_NAME}_FIND_VERSION}") | ||
| endif() | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_REQUIRED) | ||
| list(APPEND find_package_arguments REQUIRED) | ||
| endif() | ||
| if(${CMAKE_FIND_PACKAGE_NAME}_FIND_QUIETLY) | ||
| list(APPEND find_package_arguments QUIET) | ||
| endif() | ||
| find_package(Arrow ${find_package_arguments}) | ||
| find_package(ArrowEngine ${find_package_arguments}) | ||
|
|
||
| if(ARROW_FOUND AND ARROW_DATASET_FOUND) | ||
| arrow_find_package(ARROW_ENGINE | ||
| "${ARROW_HOME}" | ||
| arrow_engine | ||
| arrow/engine/api.h | ||
| ArrowEngine | ||
| arrow-engine) | ||
| if(NOT ARROW_ENGINE_VERSION) | ||
| set(ARROW_ENGINE_VERSION "${ARROW_VERSION}") | ||
| endif() | ||
| endif() | ||
|
|
||
| if("${ARROW_ENGINE_VERSION}" VERSION_EQUAL "${ARROW_VERSION}") | ||
| set(ARROW_ENGINE_VERSION_MATCH TRUE) | ||
| else() | ||
| set(ARROW_ENGINE_VERSION_MATCH FALSE) | ||
| endif() | ||
|
|
||
| mark_as_advanced(ARROW_ENGINE_IMPORT_LIB | ||
| ARROW_ENGINE_INCLUDE_DIR | ||
| ARROW_ENGINE_LIBS | ||
| ARROW_ENGINE_LIB_DIR | ||
| ARROW_ENGINE_SHARED_IMP_LIB | ||
| ARROW_ENGINE_SHARED_LIB | ||
| ARROW_ENGINE_STATIC_LIB | ||
| ARROW_ENGINE_VERSION | ||
| ARROW_ENGINE_VERSION_MATCH) | ||
|
|
||
| find_package_handle_standard_args(ArrowEngine | ||
| REQUIRED_VARS | ||
| ARROW_ENGINE_INCLUDE_DIR | ||
| ARROW_ENGINE_LIB_DIR | ||
| ARROW_ENGINE_VERSION_MATCH | ||
| VERSION_VAR | ||
| ARROW_ENGINE_VERSION) | ||
| set(ARROW_ENGINE_FOUND ${ArrowEngine_FOUND}) | ||
|
|
||
| if(ArrowEngine_FOUND AND NOT ArrowEngine_FIND_QUIETLY) | ||
| message(STATUS "Found the Arrow Engine by ${ARROW_ENGINE_FIND_APPROACH}") | ||
| message( | ||
| STATUS "Found the Arrow Engine shared library: ${ARROW_ENGINE_SHARED_LIB}" | ||
| ) | ||
| message( | ||
| STATUS "Found the Arrow Engine import library: ${ARROW_ENGINE_IMPORT_LIB}" | ||
| ) | ||
| message( | ||
| STATUS "Found the Arrow Engine static library: ${ARROW_ENGINE_STATIC_LIB}" | ||
| ) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -586,6 +586,10 @@ if(ARROW_DATASET) | |
| add_subdirectory(dataset) | ||
| endif() | ||
|
|
||
| if(ARROW_ENGINE) | ||
| add_subdirectory(engine) | ||
|
||
| endif() | ||
|
|
||
| if(ARROW_FILESYSTEM) | ||
| add_subdirectory(filesystem) | ||
| endif() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # This config sets the following variables in your project:: | ||
| # | ||
| # ArrowEngine_FOUND - true if Arrow Query engine is found on the system | ||
| # | ||
| # This config sets the following targets in your project:: | ||
| # | ||
| # arrow_engine_shared - for linked as shared library if shared library is built | ||
| # arrow_engine_static - for linked as static library if static library is built | ||
|
|
||
| @PACKAGE_INIT@ | ||
|
|
||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(Arrow) | ||
| find_dependency(ArrowDataset) | ||
|
|
||
| # Load targets only once. If we load targets multiple times, CMake reports | ||
| # already existent target error. | ||
| if(NOT (TARGET arrow_engine_shared OR TARGET arrow_engine_static)) | ||
| include("${CMAKE_CURRENT_LIST_DIR}/ArrowEngineTargets.cmake") | ||
| endif() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to bikeshed about this but
ARROW_QUERY_ENGINEor something more "obvious" might aid readability, unless we come up with some other name for the project