ARROW-8081: [Plasma] Fix memory limit bug & improve code #6587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready for review now. |
Contributor
Author
|
Hi @pcmoritz, could you help reviewing this PR? Thanks! |
Contributor
Author
|
Re-trigger all tests since there are random failures. |
Contributor
|
Hi @suquark sorry for the late response. It looks like there are merge conflicts now, would you mind rebasing and I can take a look afterwards? |
Member
|
@suquark could you take a look? |
Member
|
I'm closing this. We need to have a discussion about the future of this code on the mailing list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://issues.apache.org/jira/browse/ARROW-8081
The memory limit was set at the
getoptsection. I fix it by moving this part to somewhere later than the huge pages section. Also I find mixed use ofchar *andstd::stringfor socket names, and now they are all usingstd::stringnow.Also convert
ARROW_CHECK_OKtoASSERT_OKbecause all other unit tests in Arrow are usingASSERT_OKnow.