Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Mar 13, 2020

The root cause that the macos sdk headers are no longer installed, don't know why wasn't it an issue previously (perhaps travis has changed something or we changed something in the build config), investigating it.

@kszucs
Copy link
Member Author

kszucs commented Mar 13, 2020

@github-actions crossbow submit wheel-osx-cp38

@github-actions
Copy link

Revision: 608cdb3

Submitted crossbow builds: ursa-labs/crossbow @ actions-4

Task Status
wheel-osx-cp38 TravisCI

@kszucs
Copy link
Member Author

kszucs commented Mar 13, 2020

The issue first appeared 8 days ago.

@kszucs
Copy link
Member Author

kszucs commented Mar 13, 2020

Probably here is the commit which has caused the regression 6fa6c91

@kszucs
Copy link
Member Author

kszucs commented Mar 13, 2020

@github-actions crossbow submit wheel-osx-cp38

@github-actions
Copy link

Revision: 7f2ec9546a4ca8adac2f57027002af02efc43218

Submitted crossbow builds: ursa-labs/crossbow @ actions-5

Task Status
wheel-osx-cp38 TravisCI

@github-actions
Copy link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like passing CC causes the issue, need to investigate it in more detail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS SDK headers are no longer installed under /usr/include so when we use system clang it cannot find its headers unless we explicitly pass the SDK path CFLAGS.

@kszucs
Copy link
Member Author

kszucs commented Mar 16, 2020

@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38

@github-actions
Copy link

Revision: fa25999

Submitted crossbow builds: ursa-labs/crossbow @ actions-10

Task Status
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI

@kszucs
Copy link
Member Author

kszucs commented Mar 16, 2020

Passing CFLAGS has resolved the bzip2_ep build issue, so this should resolve the immediate issue with the OSX wheels, although we might want to have a general solution for the missing OSX SDK headers in cmake. cc @xhochy

@kszucs
Copy link
Member Author

kszucs commented Mar 16, 2020

The build failures should be fixed by #6633

@kou
Copy link
Member

kou commented Mar 16, 2020

I think that exporting the SDKROOT environment variable like #5756 will fix this.

@kszucs
Copy link
Member Author

kszucs commented Mar 16, 2020

Thanks for the suggestion, I'm going to try it.

@kou
Copy link
Member

kou commented Mar 17, 2020

@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38

@github-actions
Copy link

Revision: edb410a

Submitted crossbow builds: ursa-labs/crossbow @ actions-14

Task Status
wheel-osx-cp35m TravisCI
wheel-osx-cp36m TravisCI
wheel-osx-cp37m TravisCI
wheel-osx-cp38 TravisCI

@kou
Copy link
Member

kou commented Mar 18, 2020

+1
Bzip2 build works with SDKROOT.

@kou kou closed this in 5f3504e Mar 18, 2020
@kszucs
Copy link
Member Author

kszucs commented Mar 18, 2020

Thanks @kou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants