-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-8092: [CI][Crossbow] OSX wheels fail on bundled bzip2 #6616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit wheel-osx-cp38 |
|
Revision: 608cdb3 Submitted crossbow builds: ursa-labs/crossbow @ actions-4
|
|
The issue first appeared 8 days ago. |
|
Probably here is the commit which has caused the regression 6fa6c91 |
|
@github-actions crossbow submit wheel-osx-cp38 |
|
Revision: 7f2ec9546a4ca8adac2f57027002af02efc43218 Submitted crossbow builds: ursa-labs/crossbow @ actions-5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like passing CC causes the issue, need to investigate it in more detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS SDK headers are no longer installed under /usr/include so when we use system clang it cannot find its headers unless we explicitly pass the SDK path CFLAGS.
|
@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38 |
|
Revision: fa25999 Submitted crossbow builds: ursa-labs/crossbow @ actions-10
|
|
Passing CFLAGS has resolved the bzip2_ep build issue, so this should resolve the immediate issue with the OSX wheels, although we might want to have a general solution for the missing OSX SDK headers in cmake. cc @xhochy |
|
The build failures should be fixed by #6633 |
|
I think that exporting the |
|
Thanks for the suggestion, I'm going to try it. |
|
@github-actions crossbow submit wheel-osx-cp35m wheel-osx-cp36m wheel-osx-cp37m wheel-osx-cp38 |
|
Revision: edb410a Submitted crossbow builds: ursa-labs/crossbow @ actions-14
|
|
+1 |
|
Thanks @kou! |
The root cause that the macos sdk headers are no longer installed, don't know why wasn't it an issue previously (perhaps travis has changed something or we changed something in the build config), investigating it.