Skip to content

ARROW-7771: [Developer] Use ARROW_TMPDIR environment variable in the verification scripts instead of TMPDIR #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kszucs wants to merge 1 commit into from
Closed

ARROW-7771: [Developer] Use ARROW_TMPDIR environment variable in the verification scripts instead of TMPDIR #6718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# If using a non-system Boost, set BOOST_ROOT and add Boost libraries to
# LD_LIBRARY_PATH.
#
# To reuse build artifacts between runs set TMPDIR environment variable to
# To reuse build artifacts between runs set ARROW_TMPDIR environment variable to
# a directory where the temporary files should be placed to, note that this
# directory is not cleaned up automatically.

Expand Down Expand Up @@ -203,19 +203,19 @@ test_yum() {
setup_tempdir() {
cleanup() {
if [ "${TEST_SUCCESS}" = "yes" ]; then
rm -fr "${TMPDIR}"
rm -fr "${ARROW_TMPDIR}"
else
echo "Failed to verify release candidate. See ${TMPDIR} for details."
echo "Failed to verify release candidate. See ${ARROW_TMPDIR} for details."
fi
}

if [ -z "${TMPDIR}" ]; then
# clean up automatically if TMPDIR is not defined
TMPDIR=$(mktemp -d -t "$1.XXXXX")
if [ -z "${ARROW_TMPDIR}" ]; then
# clean up automatically if ARROW_TMPDIR is not defined
ARROW_TMPDIR=$(mktemp -d -t "$1.XXXXX")
trap cleanup EXIT
else
# don't clean up automatically
mkdir -p "${TMPDIR}"
mkdir -p "${ARROW_TMPDIR}"
fi
}

Expand Down Expand Up @@ -539,8 +539,8 @@ clone_testing_repositories() {
}

test_source_distribution() {
export ARROW_HOME=$TMPDIR/install
export PARQUET_HOME=$TMPDIR/install
export ARROW_HOME=$ARROW_TMPDIR/install
export PARQUET_HOME=$ARROW_TMPDIR/install
export LD_LIBRARY_PATH=$ARROW_HOME/lib:${LD_LIBRARY_PATH:-}
export PKG_CONFIG_PATH=$ARROW_HOME/lib/pkgconfig:${PKG_CONFIG_PATH:-}

Expand Down Expand Up @@ -747,8 +747,8 @@ esac
TEST_SUCCESS=no

setup_tempdir "arrow-${VERSION}"
echo "Working in sandbox ${TMPDIR}"
cd ${TMPDIR}
echo "Working in sandbox ${ARROW_TMPDIR}"
cd ${ARROW_TMPDIR}

setup_miniconda
echo "Using miniconda environment ${MINICONDA}"
Expand Down