ARROW-8225: [Rust] Rust Arrow IPC reader must respect continuation markers. #6724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A continuation marker (value of 0xffffffff) in a message size block is used to align the next block to an 8-byte boundary. This value needs to be skipped over if encountered.
paddyhoran
changed the title
paddyhoran
approved these changes
Mar 26, 2020
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
LGTM pending CI (looks like you have some lints to fix)
Contributor
Author
|
Saw those; not sure why they came up because I hadn't changed those files, perhaps they were from another merge? Anyways, working to fix! |
Contributor
|
Yea, it happens. I guess |
Contributor
Author
|
@paddyhoran All clear! |
Member
|
You've got a conflict from the testing submodule. I'm unable to edit your branch to fix it -- I pushed a fixed branch here https://github.com/wesm/arrow/tree/rust_continuation |
Contributor
Author
|
Right, sorry, fixed. |
Member
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation marker (value of 0xffffffff) in a message size block is
used to align the next block to an 8-byte boundary. This value needs to
be skipped over if encountered.