-
Notifications
You must be signed in to change notification settings - Fork 4k
[WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter #6731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sbinet do you know if there is any interest in moving this forward? |
|
not from my end, but happy to review it nonetheless. |
|
I am looking to try this out. Might as well create examples similar to https://github.com/apache/arrow/tree/master/java/flight/flight-core/src/main/java/org/apache/arrow/flight/example @sbinet should I wait for merge before adding anything new? |
| syntax = "proto3"; | ||
|
|
||
| option java_package = "org.apache.arrow.flight.impl"; | ||
| option go_package = "ipc"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use flight namespace, there's already a component named ipc in the C++ code base and this could bring confusion.
|
Created https://jira.apache.org/jira/browse/ARROW-8601 for this |
|
Hi All, |
|
I would be very interested in using this if it moves forward.. (Native Go, and from WASM) |
|
@sbinet did you ever take a look at this? Seems this has stalled? |
|
I took a stab at building this out and adding more to it but I'm not sure what the etiquette here would be. Should I make a new PR or should I try pushing to this PR? for reference here's my branch: zeroshade@0fad81c |
|
@zeroshade I have no problem if you want to create a new PR to take over this work. I would love to see something functional land in the Go implementation. |
|
Closing this out as it appears #8175 supercedes it. |
Built out from #6731 with some inspiration from the existing Reader/Writer and the C++ Flight implementation. Still need to build out the tests some more, but would like to get opinions and thoughts on what I've got so far as I continue to build it out. Closes #8175 from zeroshade/zeroshade/go/flight Authored-by: Matthew Topol <mtopol@factset.com> Signed-off-by: Wes McKinney <wesm@apache.org>
Built out from apache/arrow#6731 with some inspiration from the existing Reader/Writer and the C++ Flight implementation. Still need to build out the tests some more, but would like to get opinions and thoughts on what I've got so far as I continue to build it out. Closes #8175 from zeroshade/zeroshade/go/flight Authored-by: Matthew Topol <mtopol@factset.com> Signed-off-by: Wes McKinney <wesm@apache.org>
Built out from apache/arrow#6731 with some inspiration from the existing Reader/Writer and the C++ Flight implementation. Still need to build out the tests some more, but would like to get opinions and thoughts on what I've got so far as I continue to build it out. Closes #8175 from zeroshade/zeroshade/go/flight Authored-by: Matthew Topol <mtopol@factset.com> Signed-off-by: Wes McKinney <wesm@apache.org>
DO NOT MERGE
I wanted make the initial code I wrote to support Apache Flight in Go available to others. We may be able to collaborate and move this forward.
I had success using this with InfluxDB and pandas.