Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions cpp/cmake_modules/FindRe2.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
##############################################################################
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
##############################################################################

# - Find re2 headers and lib.
# RE2_HOME hints the location
# This module defines
# RE2_INCLUDE_DIR, directory containing headers
# RE2_STATIC_LIB, path to libre2.a
# re2 imported static library
# RE2_FOUND, whether re2 has been found

set(RE2_SEARCH_HEADER_PATHS ${RE2_HOME}/include)

set(RE2_SEARCH_LIB_PATHS ${RE2_HOME}/lib)

find_path(RE2_INCLUDE_DIR re2/re2.h
PATHS ${RE2_SEARCH_HEADER_PATHS}
NO_DEFAULT_PATH
DOC "Google's re2 regex header path"
)

find_library(RE2_LIBS NAMES re2
PATHS ${RE2_SEARCH_LIB_PATHS}
NO_DEFAULT_PATH
DOC "Google's re2 regex library"
)

find_library(RE2_STATIC_LIB NAMES libre2${CMAKE_STATIC_LIBRARY_SUFFIX}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this so it will work on MSVC? I suppose it is somewhat moot until we use the library for something

Copy link
Contributor Author

@maxhora maxhora May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesm, I have tested this with MSVC and it was able to find library, if it was manually named "libre2.lib". But expected name of static lib on Windows is the question. Have checked cmake script of re2 lib itself, but it doesn't name static build differently to shared build. To have universal solution, it might make sense to introduce configurable separate variable RE2_STATIC_LIB_NAME.

PATHS ${RE2_SEARCH_LIB_PATHS}
NO_DEFAULT_PATH
DOC "Google's re2 regex static library"
)

message(STATUS ${RE2_INCLUDE_DIR})

if (NOT RE2_INCLUDE_DIR OR NOT RE2_LIBS OR
NOT RE2_STATIC_LIB)
set(RE2_FOUND FALSE)
message(FATAL_ERROR "Re2 includes and libraries NOT found. "
"Looked for headers in ${RE2_SEARCH_HEADER_PATHS}, "
"and for libs in ${RE2_SEARCH_LIB_PATHS}")
else()
set(RE2_FOUND TRUE)
add_library(re2 STATIC IMPORTED)
set_target_properties(re2 PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}")
endif()

mark_as_advanced(
RE2_INCLUDE_DIR
RE2_LIBS
RE2_STATIC_LIB
re2
)