ARROW-8410: [C++] Fix compilation errors on modest ARMv8 platforms (rockpro64, rpi4) #6907
Conversation
| define_option_string(ARROW_ARMV8_ARCH "Arm64 arch and extensions" "armv8-a+crc+crypto") | ||
| define_option_string(ARROW_ARMV8_ARCH | ||
| "Arm64 arch and extensions" | ||
| "" # default to None |
There was a problem hiding this comment.
We can change the default value to "armv8-a"
There was a problem hiding this comment.
I'll check this out on my rockpro64 and then make the changes below if all looks good
| set(ARROW_ALTIVEC_FLAG "-maltivec") | ||
| check_cxx_compiler_flag(${ARROW_ALTIVEC_FLAG} CXX_SUPPORTS_ALTIVEC) | ||
| elseif(ARROW_CPU_FLAG STREQUAL "arm") | ||
| elseif(ARROW_CPU_FLAG STREQUAL "arm" AND NOT ("${ARROW_ARMV8_ARCH}" STREQUAL "")) |
There was a problem hiding this comment.
then this change is not necessary
| endif() | ||
|
|
||
| if(ARROW_CPU_FLAG STREQUAL "arm") | ||
| if(ARROW_CPU_FLAG STREQUAL "arm" AND NOT ("${ARROW_ARMV8_ARCH}" STREQUAL "")) |
There was a problem hiding this comment.
and this change not necessary too
Maybe pass |
Having the default build fail on some ARMv8 platforms (on "unserious" ones, I guess =) ) doesn't seem right to me. I would push back against having |
|
@pitrou thoughts? |
|
@wesm can you test this with docker? probably need to add to the volumes section of docker-compose.yml arm64v8-conda-cache:
arm64v8-cuda-9.1-cache:
arm64v8-cuda-10.0-cache:
arm64v8-cuda-10.1-cache:
arm64v8-debian-9-cache:
arm64v8-debian-10-cache:
arm64v8-fedora-30-cache:
arm64v8-ubuntu-14.04-cache:
arm64v8-ubuntu-16.04-cache:
arm64v8-ubuntu-18.04-cache:
arm64v8-ubuntu-20.04-cache: |
|
@kszucs I'd rather not fiddle more with this, we can tackle Dockerizing the ARM tests in a subsequent PR |
4 participants
These platforms don't support
-march=armv8-a+crc+cryptoso don't think this makes sense to have as a default.Since ORC has released since a build flag was added to turn off
-WerrorI've upgraded it here and removed the previous warning workaroundsThis also resolves ARROW-7968