Skip to content

ARROW-1692: [Java] UnionArray round trip not working #7290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rymurr wants to merge 1 commit into from
Closed

ARROW-1692: [Java] UnionArray round trip not working #7290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev/archery/archery/integration/datagen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,6 @@ def _temp_path():

generate_unions_case()
.skip_category('Go')
.skip_category('Java') # TODO(ARROW-1692)
.skip_category('JS')
.skip_category('Rust'),

Expand Down
2 changes: 2 additions & 0 deletions dev/archery/archery/integration/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ def _gold_tests(self, gold_dir):
if f.name == name).skip
except StopIteration:
skip = set()
if name == 'union' and prefix == '0.17.1':
Copy link
Contributor Author

@rymurr rymurr Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor hack to remove Java from 0.17.1 union gold tests. Not the most elegant way to do it but doing it correctly would be a non-trivial change to archery imho. Thoughts?

Copy link
Contributor

@emkornfield emkornfield Jul 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I think this is OK for now.

skip.add("Java")
yield datagen.File(name, None, None, skip=skip, path=out_path)

def _run_test_cases(self, producer, consumer, case_runner,
Expand Down
Loading