Skip to content

ARROW-8929: [C++] Set the default for compute::Arity::VarArgs to 0 #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 1 commit into from
Closed

ARROW-8929: [C++] Set the default for compute::Arity::VarArgs to 0 #7322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cpp/src/arrow/compute/function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ struct ARROW_EXPORT Arity {
static Arity Ternary() { return Arity(3, false); }

/// \brief A function taking a variable number of arguments
static Arity VarArgs(int min_args = 1) { return Arity(min_args, true); }
///
/// \param[in] min_args the minimum number of arguments required when
/// invoking the function
static Arity VarArgs(int min_args = 0) { return Arity(min_args, true); }

explicit Arity(int num_args, bool is_varargs = false)
: num_args(num_args), is_varargs(is_varargs) {}
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/compute/function_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ TEST(Arity, Basics) {
ASSERT_EQ(3, ternary.num_args);

auto varargs = Arity::VarArgs();
ASSERT_EQ(1, varargs.num_args);
ASSERT_EQ(0, varargs.num_args);
ASSERT_TRUE(varargs.is_varargs);

auto varargs2 = Arity::VarArgs(2);
Expand Down