ARROW-8510: [C++][Datasets] Do not use variant in WritePlan to fix compiler error with VS 2017 #7419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I also agree with the sentiment on variant, I noted this here (which touches the same code path). While variant can elegantly solve issues in other languages, e.g. rust enums, it diverges from our current usage of interfaces and inheritance and seems to break some compilers. |
Member
Author
|
+1. Appveyor build https://ci.appveyor.com/project/wesm/arrow/builds/33486331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even without the compiler error on VS 2017 I am not a fan of using variant to solve problems like these (so to me this new code is strictly preferable to the old code), nor exposing a variant in public (or "public") APIs unless it is definitely needed.