Skip to content

ARROW-9031: [R] Implement conversion from Type::UINT64 to R vector #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nealrichardson wants to merge 2 commits into from
Closed

ARROW-9031: [R] Implement conversion from Type::UINT64 to R vector #7455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faaa04a
ARROW-9031: [R] Implement conversion from Type::UINT64 to R vector
nealrichardson Jun 16, 2020
35f6835
Update type map docs
nealrichardson Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions r/src/array_to_vector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,10 @@ std::shared_ptr<Converter> Converter::Make(const std::shared_ptr<DataType>& type
return std::make_shared<arrow::r::Converter_Promotion<REALSXP, arrow::UInt32Type>>(
std::move(arrays));

case Type::UINT64:
return std::make_shared<arrow::r::Converter_Promotion<REALSXP, arrow::UInt64Type>>(
std::move(arrays));

case Type::HALF_FLOAT:
return std::make_shared<
arrow::r::Converter_Promotion<REALSXP, arrow::HalfFloatType>>(
Expand Down
8 changes: 8 additions & 0 deletions r/tests/testthat/test-Array.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,14 @@ test_that("Array<int8>$as_vector() converts to integer (ARROW-3794)", {
expect_equal(a$as_vector(), 0:255)
})

test_that("Arrays of uint{32,64} convert to numeric", {
u32 <- Array$create(1L)$cast(uint32())
expect_identical(as.vector(u32), 1)

u64 <- Array$create(1L)$cast(uint64())
expect_identical(as.vector(u64), 1)
})
Copy link
Member

@pitrou pitrou Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are thorough!


test_that("Array$create() recognise arrow::Array (ARROW-3815)", {
a <- Array$create(1:10)
expect_equal(a, Array$create(a))
Expand Down
2 changes: 1 addition & 1 deletion r/vignettes/arrow.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ In the tables, entries with a `-` are not currently implemented.
| uint8 | integer |
| uint16 | integer |
| uint32 | double |
| uint64 | - |
| uint64 | double |
| float16 | - |
| float32 | double |
| float64 | double |
Expand Down