ARROW-9122: [C++] Properly handle sliced arrays in ascii_lower, ascii_upper kernels #7458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Jun 17, 2020
| @@ -56,12 +56,14 @@ TYPED_TEST(TestStringKernels, AsciiLength) { | |||
| "[3, null, 0, 1]"); | |||
| } | |||
|
|
|||
| TYPED_TEST(TestStringKernels, DISABLED_AsciiUpper) { | |||
| TYPED_TEST(TestStringKernels, AsciiUpper) { | |||
| this->CheckUnary("ascii_upper", "[]", this->string_type(), "[]"); | |||
Member
There was a problem hiding this comment.
Does this implicitly test sliced arrays?
Member
Author
bkietz
reviewed
Jun 17, 2020
Member
Author
|
+1, merge on green |
Member
Author
|
the test failure is an s390x flake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must both take into account the referenced range of the data buffer and shift the value offsets if the array slice offset is nonzero.